Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api interop layer deploy #1825

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

jamestranovich-noaa
Copy link
Collaborator

@jamestranovich-noaa jamestranovich-noaa commented Sep 25, 2024

What does this PR do? 🛠️

Addresses #1791 -- except, in james, and not sandbox, since I don't think we're quite set up on that front (yet)

What does the reviewer need to know? 🤔

This only works in james currently. Visit https://api-weathergov-james.app.cloud.gov/ (by default the app will return { ok: true } for /)

Also, https://weathergov-james.app.cloud.gov/ uses the interop layer by default now. Feel free to poke around.

Also, NR logs are enabled:

image

Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One general question though -- why is the main app only set to 256M? Seems small?

@jamestranovich-noaa
Copy link
Collaborator Author

@greg-does-weather @eric-gade i've made some changes to this PR, mostly making sure all of the env variables are properly propagated. please take another look 👀

@jamestranovich-noaa
Copy link
Collaborator Author

One general question though -- why is the main app only set to 256M? Seems small?

Yes. cloud.gov apps don't need that much memory because (ostensibly) it's running only that one app. The good thing is that NR will track app utilization for us and we can set warnings if we are running out of memory or disk or whatever.

It looks like we currently have 5G across all environments/instances. (To check the quota, you can get the quota id from cf org nws-weathergov and then doing cf quota <id>)

@eric-gade
Copy link
Collaborator

Note that this also closes the specific issue outlined in #1786

web/modules/weather_data/src/Service/DataLayer.php Outdated Show resolved Hide resolved
api-interop-layer/util/fetch.js Outdated Show resolved Hide resolved
docker-compose.test.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
manifests/manifest-design.yaml Outdated Show resolved Hide resolved
@jamestranovich-noaa jamestranovich-noaa merged commit dc286fd into api-interop-layer Oct 1, 2024
14 of 19 checks passed
@jamestranovich-noaa jamestranovich-noaa deleted the jt/api-interop-layer-deploy branch October 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants