-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api interop layer deploy #1825
api interop layer deploy #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One general question though -- why is the main app only set to 256M
? Seems small?
61bdf9e
to
9a65274
Compare
00bc002
to
1fd69f7
Compare
b686bc3
to
4c0a9bf
Compare
a0c190e
to
30d9136
Compare
@greg-does-weather @eric-gade i've made some changes to this PR, mostly making sure all of the env variables are properly propagated. please take another look 👀 |
Yes. cloud.gov apps don't need that much memory because (ostensibly) it's running only that one app. The good thing is that NR will track app utilization for us and we can set warnings if we are running out of memory or disk or whatever. It looks like we currently have 5G across all environments/instances. (To check the quota, you can get the quota id from |
Note that this also closes the specific issue outlined in #1786 |
What does this PR do? 🛠️
Addresses #1791 -- except, in james, and not sandbox, since I don't think we're quite set up on that front (yet)
What does the reviewer need to know? 🤔
This only works in
james
currently. Visit https://api-weathergov-james.app.cloud.gov/ (by default the app will return{ ok: true }
for/
)Also, https://weathergov-james.app.cloud.gov/ uses the interop layer by default now. Feel free to poke around.
Also, NR logs are enabled: