API interop layer deploy actions #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-does-weather
force-pushed
the
api-interop-layer
branch
from
e2ba956
to
cbfb777
Compare
jamestranovich-noaa
force-pushed
the
jt/api-interop-layer-deploy-actions
branch
from
ac63d99
to
21326cb
Compare
greg-does-weather
approved these changes
Oct 10, 2024
jamestranovich-noaa
merged commit 226bf53
into
api-interop-layer
15 of 19 checks passed
jamestranovich-noaa
added a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
Sets up deploy for all environments except beta. Addresses #1731
What does the reviewer need to know? 🤔
It is not possible to have a rolling strategy for multiple apps defined in a manifest (see cloud.gov documentation). So here we are doing an app deploy one by one. Right now a "rolling" strategy doesn't matter that much because we only have one instance at any given time but it will matter when we add more instances down the line.