Set a manual node ID on the "today" tab forecast summary #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
The today tab forecast summary uses the same component as the daily forecast tab. This component automatically applies an ID to the container based on the forecast date. As a result, we end up with two nodes with the same node ID - one on the "today" tab and one on the "forecast" tab, which causes the quick forecast link to try to go to the wrong place.
This PR modifies the component so that it can accept a node ID as an argument and it will use the date if an ID is not provided, and modifies the today tab to provide an ID. This clears up the ID collision and fixes the link.