Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use full URL as metric label on unmatched path #108

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Don't use full URL as metric label on unmatched path #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions middleware/instrument.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ func (i Instrument) Wrap(next http.Handler) http.Handler {
// 2. The request matches an unamed gorilla mux router. Munge the path
// template such that templates like '/api/{org}/foo' come out as
// 'api_org_foo'.
// 3. The request doesn't match a mux route. Munge the Path in the same
// manner as (2).
// 3. The request doesn't match a mux route. Return "other"
// We do all this as we do not wish to emit high cardinality labels to
// prometheus.
func (i Instrument) getRouteName(r *http.Request) string {
Expand All @@ -74,7 +73,7 @@ func (i Instrument) getRouteName(r *http.Request) string {
return MakeLabelValue(tmpl)
}
}
return MakeLabelValue(r.URL.Path)
return "other"
}

var invalidChars = regexp.MustCompile(`[^a-zA-Z0-9]+`)
Expand Down