middleware: add a way to stop errors being logged #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. if the error is caused by overload, then we don't want to log it because that uses more resource. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
|
Moved to draft because I would like to get more agreement how this should be implemented. |
bboreham
commented
Jul 24, 2023
| @@ -83,6 +91,9 @@ func (l Log) Wrap(next http.Handler) http.Handler { | |||
| statusCode, writeErr := wrapped.getStatusCode(), wrapped.getWriteError() | |||
|
|
|||
| if writeErr != nil { | |||
| if errors.Is(writeErr, DoNotLogError{}) { | |||
There was a problem hiding this comment.
This isn't right: the writeError is an error from Write(), not the underlying operation error.
Patterned after the one for http logging.
|
Replaced by #299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. if the error is caused by overload, then we don't want to log it because that uses more resource.