Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new gRPC APIs #55

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Use new gRPC APIs #55

merged 1 commit into from
Sep 18, 2017

Conversation

jml
Copy link
Contributor

@jml jml commented Sep 18, 2017

grpc/grpc-go#1157 changed the APIs for getting
metadata from contexts and making contexts from metadata.

This PR updates common to rely on the new library.

Means that anyone who vendors common will need a recent grpc-go too.

grpc/grpc-go#1157 changed the APIs for getting
metadata from contexts and making contexts from metadata.

This PR updates common to rely on the new library.

Means that anyone who vendors common will need a recent grpc-go too.
@jml jml merged commit df441dc into master Sep 18, 2017
@jml jml deleted the update-grpc-usage branch September 18, 2017 14:22
jml added a commit that referenced this pull request Sep 18, 2017
jml added a commit that referenced this pull request Sep 18, 2017
…g on 500s" (#56)

* Revert "Use new gRPC APIs (#55)"

This reverts commit df441dc.

* Revert "Log request headers, response headers and some body as warning on 500s (#41)"

This reverts commit c8c93e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants