Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log request headers, response headers and some body as warning on 500s #59

Merged
merged 5 commits into from
Sep 20, 2017
Merged

Log request headers, response headers and some body as warning on 500s #59

merged 5 commits into from
Sep 20, 2017

Conversation

jml
Copy link
Contributor

@jml jml commented Sep 20, 2017 •
edited
Loading

Re-do of #41 which was reverted in #56 because I thought it introduced an error that stopped the users service from working. Actually, it was because of #47, which we've fixed with weaveworks/service#1374

This is mostly the same as #41, but

  • only logs 500s
  • fixes a logic bug such that we don't try to log nil headers
  • re-introduces a StatusOK thingummy, so we don't log huge amounts of information on successful requests

@jml jml requested a review from bboreham September 20, 2017 14:24
@jml jml merged commit 955c130 into master Sep 20, 2017
@jml jml deleted the log-users branch September 20, 2017 14:50
jml added a commit to weaveworks/service that referenced this pull request Sep 20, 2017
@jml
Log headers etc. on 500s
853121b 
From weaveworks/common#59

Fixes #1233
@jml jml mentioned this pull request Sep 20, 2017
Merged
@bboreham bboreham mentioned this pull request Dec 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jml @bboreham