This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make chart ops insensitive to (missing) slashes #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
1732-trailing-slash-repo-url
branch
from
fc5973f to
65f8545
Compare
Before this change it was possible that a user provided correct credentials for a repository, but the operator was unable to find them due to too strict comparisons, also, the URL the operator constructed to download a tarball of a chart was missing a path element when a given repo URL did not end with a trailing slash. To get around the first issue the repo URL from the `repositories.yaml` and the repo URL from the given HelmRelease are both stripped from their trailing slashes during comparison. To get around the second issue a CleanRepoURL function was added and implemented, which returns the RepoURL but ensures it always ends with a trailing slash.
hiddeco
force-pushed
the
1732-trailing-slash-repo-url
branch
from
65f8545 to
9978918
Compare
stefanprodan
approved these changes
Feb 14, 2019
This was referenced Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1732.
Image for testing available as
hiddeco/helm-operator:1732-trailing-slash-repo-url.