Expand on the recognised fluxd flags #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
reviewed
Jun 5, 2019
foot
reviewed
Jun 5, 2019
|
Okey doke, as there are old-school |
rade
reviewed
Jun 6, 2019
This adds to the list of fluxd flags that the agent will recognise and include in URLs. Since there are now more than four, and they don't all appear together necessarily, I've changed how the URL is constructed.
- More tests - Don't need struct flag parse annotations
|
@squaremo I’m happy to merge this it seems to work alright! The code I added is a bit rough wdyt? |
squaremo
commented
Jun 10, 2019
squaremo
force-pushed
the
more-flux-args
branch
2 times, most recently
from
3f618d5 to
3b30570
Compare
We can save the clean-up phase, which reset things to `nil` if they weren't passed as flags, by checking with the flag parser directly. This makes it trickier to construct a config (since it needs the flags parser state), but that's what `ParseFluxArgs` is for. The code that uses ParseFluxArgs is sensitive to whether it gets a `nil`, a value, or an error, so that behaviour must be preserved.
|
Awesome stuff, thanks @squaremo |
|
Where are the usage docs for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the list of fluxd flags that the agent will recognise and include in launch-generator URLs.
Since there are now more than four, and they don't all appear together necessarily, I've changed how the URL is constructed.
Fixes #277. (And needs a compensating change in the service being polled for configs.)