Enhance the details pane #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #21 |
peterbourgon
force-pushed
the
enhanced-details
branch
from
784e1a2 to
bdc6ee2
Compare
|
|
|
Steps to get a piece of data into the detail pane:
|
|
@tomwilkie ready for review, I think. This isn't a beautiful implementation but it'll do. |
peterbourgon
changed the title
| {Key: "PID", ValueMajor: node["pid"], ValueMinor: ""}, | ||
| {Key: "Process name", ValueMajor: node["name"], ValueMinor: ""}, | ||
| } | ||
| if val, ok := node["docker_id"]; ok { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Other than that one comment, LGTM. Will definitely need a rebase and squash - we don't want merge commits, gofmt fixes, circle debugging etc. I would squash into one. |
peterbourgon
force-pushed
the
enhanced-details
branch
from
aac1fe1 to
2d5f58e
Compare
|
Problem with the table approach I suggested; ordering is not stable. |
|
D'oh. Will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enhance the details struct (and thereby the details pane) with details from the origin atom (process, IP), specifically stuff like cgroup names, Docker container info, etc.