Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent toolbar #81

Merged
merged 8 commits into from
Aug 14, 2015
Merged

Consistent toolbar #81

merged 8 commits into from
Aug 14, 2015

Conversation

davkal
Copy link

@davkal davkal commented Aug 12, 2015

  • extracted toolbar and reused it in wrapper and org
  • styling, including Organization label will be done in different issue

@davkal
Copy link
Author

davkal commented Aug 12, 2015

Fixes #79

@tomwilkie tomwilkie self-assigned this Aug 12, 2015
@tomwilkie
Copy link

Feedback:

  • put all the links / icons on the right
  • make the service button a cog
  • make the logout a door
  • scope stays as text to draw attention
  • can we make user's email text smaller?
  • hide the list of users from the org page
  • add the following instructions to the org page:
sudo wget -O /usr/local/bin/scope https://git.io/scope-latest
sudo chmod a+x /usr/local/bin/scope
sudo scope launch --service-token=...
  • When no probes are listed, explicitly say "No probes attached" or such like

@tomwilkie tomwilkie assigned davkal and unassigned tomwilkie Aug 13, 2015
@davkal davkal force-pushed the 79-consistent-toolbar branch from e32fc89 to 1674030 Compare August 13, 2015 17:12
@tomwilkie tomwilkie changed the title Consisten toolbar Consistent toolbar Aug 13, 2015
@tomwilkie
Copy link

Looks good. Fonts aren't loading for me - buttons in top left are just boxes.

@tomwilkie
Copy link

"Configure your instance" -> "Configure your instances"

Then put a line of text under that say "Run the following commands on your Docker hosts to connect them to Weave Scope."

The grey text under the list of probes clashes with the background on my screen.

Feel free to commit this and fix the feedback later.

@tomwilkie
Copy link

Fixed the fonts.

Also, add a line under the logo: "Once you're started scope on your Docker hosts, click "My Scope" in the top right."

@tomwilkie
Copy link

LGTM

davkal added a commit that referenced this pull request Aug 14, 2015
@davkal davkal merged commit 87d6993 into master Aug 14, 2015
@davkal davkal deleted the 79-consistent-toolbar branch August 14, 2015 12:25
@jml jml unassigned davkal Aug 18, 2017
bboreham added a commit that referenced this pull request Jan 28, 2018
This brings in the merged commits for:
- #81 "Extend histogram buckets for a server up to 100 seconds"
- #83 "Let servers set any gRPC options they like "
- #84 "Don't log request body and headers for 502 errors"
(#82 was relaced by #83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants