Add indexer ADR #132
Add indexer ADR #132
Conversation
| // result will have "podinfo-a", "podinfo-b", but not "podinfo-d" since it is not in namespace-a | ||
| ``` | ||
|
|
||
| This works for enumerable fields, but there may be cases where we need to query against fields for which we do not know the key/value pairs. For example, if we want to query for labels on an object we run into a couple issues: |
There was a problem hiding this comment.
could you expand on what you mean with enumerable fields?
There was a problem hiding this comment.
"Enumerable" in this context means: "Fields we know exist ahead of time". We can predict that an object will have a namespace, but we cannot predict that it has any labels or what those label keys might be.
| } | ||
| }, | ||
| } | ||
| ``` |
There was a problem hiding this comment.
in my mind, i was actually thinking in a different direction where the object would look instead of
{
Cluster: "management",
Name: "podinfo-a",
Namespace: "namespace-a",
Kind: "HelmChart",
APIGroup: "apps",
APIVersion: "v1",
Labels: map[string]string{
"weave.works/templateType": "application",
}
},something like
{
Cluster: "management",
Name: "podinfo-a",
Namespace: "namespace-a",
Kind: "HelmChart",
APIGroup: "apps",
APIVersion: "v1",
TemplateType: "application",
},and the query would be
q := &query{
filters: []string{
"kind:/(HelmChart|HelmRepository)/",
"templateType: application",
},
}
to have that type of querying just via the indexer or unstructured.
do you see whether this could be feasible or what would be the major impediments for it?
There was a problem hiding this comment.
My thinking is that it would be weird to have a HelmRelease with a TemplateType key, for example. The only object with a TemplateType that is actually valid is a GitOpsTemplate.
Adding all these fields to the normalized object would take quite a bit more maintenance and involvement for someone wanting to add their new kind.
May be we can add it solely to the indexed object on .Add(). I will give that a try.
There was a problem hiding this comment.
i reminder for @enekofb is to refresh the picture on the indexes that we currently have ... cause that is also something that we could look at.
There was a problem hiding this comment.
doing some discovery in this pr weaveworks/weave-gitops-enterprise#3537
|
I started to look here with the following hypothesis to test out of reading https://blevesearch.com/docs/Index-Mapping/
When do we need mapping extensions?
|
ADR to explain the complications of labels queries