Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fix "weave ps" #2418

Merged
merged 4 commits into from
Jul 12, 2016
Merged

Fix "weave ps" #2418

merged 4 commits into from
Jul 12, 2016

Commits on Jul 5, 2016

  1. Refactor common.GetBridgeNetDev 

    - Optimize. Use LinkByName instead of iterating over list of available
  links. Linux does not support interfaces with the same names.
- Remove unnecessary indirection in utility functions which return
  common.NetDev.
    @brb
    brb committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    05baa56 View commit details
    Browse the repository at this point in the history

  2. Fix "weave ps" 

    Make sure that any network namespace changes happens at the end of
the cmd invocation. Otherwise, we are risking to end up in a situation
in which OS scheduling threads are in a "wrong" namespace.

See WithNetNS for more details.
    @brb
    brb committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    7f5c37e View commit details
    Browse the repository at this point in the history

  3. Denote WithNetNS* functions with unsafe 

    Please see #2388 (comment)
for more details.
    @brb
    brb committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    89221f1 View commit details
    Browse the repository at this point in the history

  4. Address PR comments 

    - Do not re-enter the root netns when querying weave bridge.
- Enter the root netns when constructing the predicate.
    @brb
    brb committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    0861d05 View commit details
    Browse the repository at this point in the history