Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set baseURL for text2vec-openai schema config #148

Merged
merged 4 commits into from
May 18, 2024
Merged

set baseURL for text2vec-openai schema config #148

merged 4 commits into from
May 18, 2024

Conversation

samos123
Copy link
Contributor

@samos123 samos123 commented May 7, 2024 •
edited
Loading

Fixes #147

@samos123
Copy link
Contributor Author

samos123 commented May 7, 2024 •
edited
Loading

edit: ignore, it's working now

@samos123
Copy link
Contributor Author

samos123 commented May 8, 2024

nvm it's working now. Could use a review on this.

@samos123 samos123 mentioned this pull request May 8, 2024
Closed
@thomashacker
Copy link
Collaborator

Thanks for the PR 🚀 I'll have a look

thomashacker
thomashacker approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@thomashacker thomashacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot!

@thomashacker thomashacker merged commit 940fbbf into weaviate:main May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashacker thomashacker thomashacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add baseURL config for Weaviate schema generation
2 participants
@samos123 @thomashacker