Add support for auto-tenant-activation #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
+ Coverage 94.56% 94.64% +0.08%
==========================================
Files 181 182 +1
Lines 18825 18874 +49
==========================================
+ Hits 17802 17864 +62
+ Misses 1023 1010 -13 ☔ View full report in Codecov by Sentry. |
tsmith023
approved these changes
May 29, 2024
There was a problem hiding this comment.
I added the WeaviateUnsupportedFeatureError that is starting to be used as a client-side check on exposed features compared to the server version. Perhaps it's overkill to use it here, perhaps checking the server version and whether auto_tenant_creation/auto_tenant_activation are set to True, and throw if there is an incompatibility. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.