Refactor batch results storage and publishing #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Limits total number of stored results to 100,000. Should this be configurable? - Changes `.uuids` and `.errors` to be properties that are resolved at read time - This was due to strange counting bug because of bad internal logic mapping grpc results to the data wrapper object - Is this a potentially breaking change?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
- Coverage 94.68% 94.58% -0.11%
==========================================
Files 190 191 +1
Lines 18932 18984 +52
==========================================
+ Hits 17926 17956 +30
- Misses 1006 1028 +22 ☔ View full report in Codecov by Sentry. |
dirkkul
reviewed
Jun 24, 2024
dirkkul
reviewed
Jun 26, 2024
dirkkul
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1094