Implement client features for tenant offloading #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use updated protos with new activity status enum values - Split `Tenant` and `TenantInput` due to read-only nature of new activity statuses - Allow `Tenant` in `create/update` methods but check if read-only fields are used - Introduce `TenantInputType` and `TenantOutputType` types for a simpler surface
tsmith023
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.26 #1132 +/- ##
===========================================
Coverage ? 94.57%
===========================================
Files ? 191
Lines ? 19028
Branches ? 0
===========================================
Hits ? 17996
Misses ? 1032
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
No tests? |
|
Not yet, was waiting for the core PR to be approved and ready. I'll add some mock tests since a full integration test needs a lot of infra setup |
dirkkul
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TenantandTenantInputdue to read-only nature of new activity statusesTenantincreate/updatemethods but check if read-only fields are usedTenantInputTypeandTenantOutputTypetypes for a simpler surfaceCore PR: weaviate/weaviate#5224