-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for types that are not installed #1145
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.26 #1145 +/- ##
===========================================
Coverage ? 94.52%
===========================================
Files ? 197
Lines ? 19429
Branches ? 0
===========================================
Hits ? 18365
Misses ? 1064
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Can we also improve the types of the method in |
I don't think this is possible, but I'd like to get this merged as it is currently a regression |
We accept numpy etc as vectors and convert them internally into lists. This causes problems with the new multi-vector approach, as we need to do different things depending on the input type.
This adds: