Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating quantizers between pq, bq, and sq with hnsw index #1171

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Jul 9, 2024

  • Forbid updating the quantizer of an index if it already has one configured (should be on the server but adding to client for now)
  • Add unit tests for quantizer merge_with_existing method
  • Any errors with updating quantizers for unsupported indices, e.g. pq and sq with flat, are returned from the server as UnexpectedStatusCodeError exceptions

Closes #1170

- Allow updating all quantizers
- add unit tests for quantizer merge_with_existing
@tsmith023 tsmith023 requested a review from dirkkul July 9, 2024 11:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (f19987f) to head (772c25e).
Report is 3 commits behind head on dev/1.26.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.26    #1171      +/-   ##
============================================
- Coverage     94.31%   94.30%   -0.02%     
============================================
  Files           213      215       +2     
  Lines         20490    20553      +63     
============================================
+ Hits          19325    19382      +57     
- Misses         1165     1171       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit dec088a into dev/1.26 Jul 9, 2024
50 checks passed
@tsmith023 tsmith023 deleted the 1.26/fix-updating-quantizers branch July 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants