Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore BlockingIOError error logs emitted by aio.grpc in event loops #1180

Merged

Conversation

tsmith023
Copy link
Contributor

Due to issues surrounding the core grpc cython implementation of aio.grpc.Channel.__init__, false positive error messages are emitted of the form BlockingIOError: [Errno 35] Resource temporarily unavailable when channels are used in multi-threading environments. Since such errors only occur at channel initialisation and do not affect the actual I/O requests themselves, we can safely ignore them, as is proposed to be done in grpc/grpc#36096

For now, we can here follow the same logic and implement our own custom exception handling so that the previous grpcio versions we support can continue to be supported into the future

@tsmith023 tsmith023 requested a review from dirkkul July 17, 2024 12:32
@tsmith023 tsmith023 merged commit 133e7ca into dev/1.26 Jul 17, 2024
49 of 50 checks passed
@tsmith023 tsmith023 deleted the 1.26/patch-asyncio-exception-handler-for-blockingioerror branch July 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants