Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all query stubs are aligned with new impl API surface #1181

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

tsmith023
Copy link
Contributor

No description provided.

@tsmith023 tsmith023 requested a review from dirkkul July 17, 2024 13:34
@tsmith023 tsmith023 changed the title Ensure all stubs are aligned with new impl API surface Ensure all query stubs are aligned with new impl API surface Jul 17, 2024
@tsmith023 tsmith023 requested a review from a team as a code owner July 17, 2024 13:40
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.39%. Comparing base (014412a) to head (a4f3682).
Report is 12 commits behind head on dev/1.26.

Files Patch % Lines
integration/test_client.py 93.75% 2 Missing ⚠️
weaviate/collections/batch/batch_wrapper.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.26    #1181      +/-   ##
============================================
+ Coverage     94.26%   94.39%   +0.13%     
============================================
  Files           213      215       +2     
  Lines         20490    20602     +112     
============================================
+ Hits          19314    19448     +134     
+ Misses         1176     1154      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit 256cf93 into dev/1.26 Jul 18, 2024
50 checks passed
@tsmith023 tsmith023 deleted the 1.26/fix-query-stubs-with-new-features branch July 18, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants