Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for logging errors in batch #1183

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

tsmith023
Copy link
Contributor

No description provided.

@tsmith023 tsmith023 requested a review from dirkkul July 18, 2024 13:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (014412a) to head (3ebdb25).
Report is 20 commits behind head on dev/1.26.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.26    #1183      +/-   ##
============================================
+ Coverage     94.26%   94.37%   +0.11%     
============================================
  Files           213      215       +2     
  Lines         20490    20601     +111     
============================================
+ Hits          19314    19443     +129     
+ Misses         1176     1158      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit 539d926 into dev/1.26 Jul 18, 2024
50 checks passed
@tsmith023 tsmith023 deleted the 1.26/fix-error-logging-in-batch branch July 18, 2024 14:20
@tsmith023 tsmith023 restored the 1.26/fix-error-logging-in-batch branch July 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants