Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make moduleconfig optional for custom reranker/generative #1187

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Jul 19, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.56%. Comparing base (42fb96c) to head (ffe9afc).
Report is 102 commits behind head on main.

Files Patch % Lines
weaviate/collections/classes/config.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
- Coverage   94.68%   94.56%   -0.13%     
==========================================
  Files         190      193       +3     
  Lines       18932    19250     +318     
==========================================
+ Hits        17926    18203     +277     
- Misses       1006     1047      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit a002cfa into main Jul 19, 2024
42 checks passed
@tsmith023 tsmith023 deleted the fix_optional_moduleconfig_for_custom branch July 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants