Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenization and indexSearchable parameter in to_dict of a property. ISSUE #1237 #1238

Conversation

dudanogueira
Copy link
Contributor

Fixes #1237

@dirkkul
Copy link
Collaborator

dirkkul commented Aug 13, 2024

Hey Duda, thanks for the PR - could you add a test? This would be the best location: integration/test_collection_config.py

@dudanogueira
Copy link
Contributor Author

dudanogueira commented Aug 15, 2024

Added some tests. Had to allow the factory to return the client.

While comparing different properties and configs, found some other bugs:

edit: found the issue, fixed.

for instance:

            # this was fixed:
            Property(name="field_index_searchable", data_type=DataType.TEXT, 
                     index_searchable=False), 
            # TODO: this will still fail
            Property(
                name="name",
                data_type=DataType.OBJECT,
                nested_properties=[
                    Property(name="first", data_type=DataType.TEXT),
                    Property(name="last", data_type=DataType.TEXT),
                ],
            ),

I will improve the tests further with named vectors too.

@dudanogueira dudanogueira changed the title Fix tokenization parameter in to_dict of a property. ISSUE #1237 Fix tokenization and indexSearchable parameter in to_dict of a property. ISSUE #1237 Aug 15, 2024
@dirkkul
Copy link
Collaborator

dirkkul commented Aug 20, 2024

Hey Duda, I tooke your commit and fixed the tests in this PR: #1249

@dirkkul dirkkul closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

property.to_dict() with tokenizer instead of tokenization
2 participants