Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate v3 in v4 #1239

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Deprecate v3 in v4 #1239

merged 7 commits into from
Sep 2, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Aug 14, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (6234608) to head (09d592d).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
+ Coverage   94.42%   94.47%   +0.05%     
==========================================
  Files         215      217       +2     
  Lines       20686    20758      +72     
==========================================
+ Hits        19533    19612      +79     
+ Misses       1153     1146       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daveatweaviate daveatweaviate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkkul thanks for the update, I left some suggestions on the wording

README.rst Outdated Show resolved Hide resolved
weaviate/warnings.py Outdated Show resolved Hide resolved
weaviate/warnings.py Outdated Show resolved Hide resolved
@tsmith023 tsmith023 merged commit a4b3214 into main Sep 2, 2024
50 checks passed
@tsmith023 tsmith023 deleted the deprecate_v3_in_v4 branch September 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants