-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: fetch_objects_by_ids #1241
feature: fetch_objects_by_ids #1241
Conversation
@tsmith023 Is generate.fetch_objects_by_ids also needed? I removed it in the 2nd commit for now. |
Hi @tibor-reiss, thank you so much for this contribution! I don't think implementing The linting check is failing with a
|
generate.fetch_objects_by_ids might actually make sense here if you only want to generate something for a few IDs. But that could be done in a separate PR |
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
@weaviate-git-bot I agree with the CLA |
I added back the generate part. |
Fixes #1168