Add limit parameter to client.data_object.get() REST query #181
Conversation
There was a problem hiding this comment.
BTW there are more parameters: offset, sort, order (can be "asc" or "desc"). These are the same parameters as for Get` query using GraphQL. Here is how it is done there:
- Sort/order: https://github.com/semi-technologies/weaviate-python-client/blob/main/weaviate/gql/get.py#L797-L859
- Offset: https://github.com/semi-technologies/weaviate-python-client/blob/main/weaviate/gql/get.py#L486-L512
I am not sure anyone uses them, to be honest, because with GET /objects you cannot do any filtering, so I am not sure anyone is interested in this. Also with sort/'order' I am not sure how it would work when you have multiple classes with different properties. This was kind of the reason I never added limit, and these ones I mentioned here.
Do you think we should include those as well?
Hmmm, if you don't think that anybody uses it, lets wait until people ask for it. |
|
as a user, I was expecting all parameters to be available and thought I must be missing something. I could use the order or sort parameter as well. Right now I sort the results myself in python for one of the test cases in a connector 🤦 |
|
ok, I'll create an issue for this. But I will probably not have for it this year |
closes #179