-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch objects where filter #443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 95.43% 94.51% -0.92%
==========================================
Files 64 63 -1
Lines 8165 8097 -68
==========================================
- Hits 7792 7653 -139
- Misses 373 444 +71
☔ View full report in Codecov by Sentry. |
dirkkul
reviewed
Aug 24, 2023
dirkkul
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem induced by the differing expected WhereFilter objects for the Batch delete objects REST endpoint, the filtering options on the Get GraphQL query, and the centralising Python-defined WhereFilter options.
Fundamentally, the GraphQL endpoint expects all keys as
value<>
determining the type based on the argument itself. The REST endpoint, however, expects the keys asvalue<>Array
if they are lists. Finally, the Pythonic definition of these types isvalue<>List
so conversion must be performed in each case to ensure validity of the user's request.It also updates the Weaviate CI version to the latest PATCH.