ensure client functionality is aligned with docs usage #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems surrounding passing lists to
value<>
fields and is an artefact of the previous confusions surrounding how data types must be passed to Weaviate through the GraphQL and REST functionalities.In the previous release, the hard requirement was added to the GraphQL filters when this was neither necessary nor required. This PR undoes a final aspect that was missed from the latest patch and is causing confusing errors upon usage due to the difference between the available library and the valid documentation.
A user reported the following problem in the community Slack:
The problem is these conditions that I added originally when I thought it was a requirement that the argument
value<>
match the value when making a where filter. This is only true ofbatch.delete_objects
and not ofgql.filter
so it is leading to bugs since the docs report thatvalue<>
is used with an array argument[]
, e.g."valueInt": [1]
etc.So it will no longer throw a client error when users say
"valueText": [tag]
, only throwing an error if they say"valueTextArray": tag
, since that is demonstrably incorrect whereas the first is only semantically incorrect (it still works with Weaviate despite having confusing wording).