Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch delete with operands #479

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Conversation

tsmith023
Copy link
Contributor

This PR resolves the bug raised in #477 where the operands key was not being checked appropriately during batch delete operations

integration/test_batch.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.83% and project coverage change: -0.55% ⚠️

Comparison is base (eb3bf16) 95.43% compared to head (b5c78ed) 94.88%.
Report is 127 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   95.43%   94.88%   -0.55%     
==========================================
  Files          64       72       +8     
  Lines        8165     8608     +443     
==========================================
+ Hits         7792     8168     +376     
- Misses        373      440      +67     
Files Changed Coverage Δ
weaviate/util.py 90.98% <67.50%> (-5.35%) ⬇️
weaviate/batch/crud_batch.py 77.66% <70.29%> (-17.66%) ⬇️
weaviate/connect/connection.py 89.12% <80.00%> (+0.18%) ⬆️
weaviate/gql/aggregate.py 82.97% <85.45%> (+7.11%) ⬆️
weaviate/schema/crud_schema.py 82.48% <86.20%> (+4.33%) ⬆️
mock_tests/test_exception.py 87.50% <87.50%> (ø)
weaviate/exceptions.py 90.69% <87.50%> (-0.74%) ⬇️
weaviate/gql/filter.py 93.92% <92.92%> (-0.43%) ⬇️
integration/test_schema.py 97.14% <93.87%> (-2.86%) ⬇️
integration/test_batch.py 98.43% <100.00%> (+0.39%) ⬆️
... and 24 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 merged commit 5cd711f into main Sep 7, 2023
19 checks passed
@tsmith023 tsmith023 deleted the fix-batch-delete-with-operands branch September 7, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants