Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tenant to failed objects #572

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tsmith023
Copy link
Contributor

This PR fixes an issue whereby a failed batch insertion of an object with multi-tenancy would subsequently retry the object without its tenant specified

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e5f5d85) 94.75% compared to head (a3a11eb) 94.75%.

Additional details and impacted files
@@              Coverage Diff              @@
##           stable/v3.24     #572   +/-   ##
=============================================
  Coverage         94.75%   94.75%           
=============================================
  Files                70       70           
  Lines              8492     8492           
=============================================
  Hits               8047     8047           
  Misses              445      445           
Files Coverage Δ
weaviate/batch/requests.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit 8da29dc into stable/v3.24 Oct 4, 2023
23 checks passed
@tsmith023 tsmith023 deleted the fix/add-tenant-to-batch-retries branch October 4, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants