Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc to new v1 proto schema #574

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Update grpc to new v1 proto schema #574

merged 8 commits into from
Oct 17, 2023

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Oct 16, 2023

This PR updates the underlying gRPC connection to use the latest protobuf files in preparation for the next release

In the process, it refactors the codebase file structure and gRPC generation scripts

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (7528726) 94.75% compared to head (db37f72) 94.10%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   94.75%   94.10%   -0.66%     
==========================================
  Files          70       72       +2     
  Lines        8492     8640     +148     
==========================================
+ Hits         8047     8131      +84     
- Misses        445      509      +64     
Files Coverage Δ
integration/test_batch.py 98.54% <100.00%> (+0.10%) ⬆️
integration/test_cluster.py 100.00% <100.00%> (ø)
integration/test_crud.py 100.00% <100.00%> (ø)
integration/test_graphql.py 94.44% <100.00%> (+0.29%) ⬆️
integration/test_schema.py 97.54% <100.00%> (+0.17%) ⬆️
test/test_client.py 100.00% <100.00%> (ø)
test/test_embedded.py 97.77% <100.00%> (+0.21%) ⬆️
weaviate/batch/requests.py 100.00% <ø> (ø)
weaviate/client.py 98.66% <100.00%> (ø)
weaviate/connect/authentication.py 96.15% <100.00%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 changed the title Update grpc to new v1 Update grpc to new v1 and support nested objects Oct 16, 2023
@tsmith023 tsmith023 changed the title Update grpc to new v1 and support nested objects Update grpc to new v1 proto schema Oct 16, 2023
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 marked this pull request as ready for review October 17, 2023 14:43
@tsmith023 tsmith023 requested a review from a team as a code owner October 17, 2023 14:43
@tsmith023 tsmith023 merged commit cab037c into main Oct 17, 2023
24 checks passed
@tsmith023 tsmith023 deleted the update-grpc-to-new-v1 branch October 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants