Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded check #857

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Remove unneeded check #857

merged 2 commits into from
Feb 6, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Feb 6, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 265 lines in your changes are missing coverage. Please review.

Comparison is base (e977081) 93.48% compared to head (5a9dfad) 95.51%.
Report is 91 commits behind head on main.

Files Patch % Lines
integration/test_collection_openai.py 41.25% 84 Missing ⚠️
weaviate/collections/batch/base.py 82.10% 51 Missing ⚠️
integration/test_collection_rerank.py 32.69% 35 Missing ⚠️
integration/test_batch_v4.py 95.08% 14 Missing ⚠️
integration_v3/test_backup_v4.py 92.76% 11 Missing ⚠️
mock_tests/test_collection.py 85.71% 10 Missing ⚠️
weaviate/collections/aggregations/base.py 94.57% 9 Missing ⚠️
weaviate/collections/batch/batch_wrapper.py 86.20% 8 Missing ⚠️
integration/conftest.py 88.52% 7 Missing ⚠️
integration/test_collection_aggregate.py 97.41% 7 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   93.48%   95.51%   +2.02%     
==========================================
  Files          70      167      +97     
  Lines        8625    17138    +8513     
==========================================
+ Hits         8063    16369    +8306     
- Misses        562      769     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul requested a review from a team as a code owner February 6, 2024 06:03
@dirkkul dirkkul merged commit cb927f1 into main Feb 6, 2024
35 checks passed
@dirkkul dirkkul deleted the small_performance_improvement branch February 6, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants