Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect declarationDir if dts.distPath is not set #420

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Timeless0911
Copy link
Collaborator

Summary

The bundleless dts emit path should follow priority of:

  1. dts.distPath
  2. declarationDir
  3. output.distPath.root

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 71ee805
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67347d6c68004e00081c93dc
😎 Deploy Preview https://deploy-preview-420--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #420 will not alter performance

Comparing fix/respect-declarationDir (71ee805) with main (dacb1d2)

Summary

✅ 5 untouched benchmarks

@Timeless0911 Timeless0911 merged commit c37f3a0 into main Nov 13, 2024
21 checks passed
@Timeless0911 Timeless0911 deleted the fix/respect-declarationDir branch November 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants