Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parse with comments #2367

Merged
merged 5 commits into from
Mar 20, 2023
Merged

feat: parse with comments #2367

merged 5 commits into from
Mar 20, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Mar 20, 2023 •
edited
Loading

Summary

  1. prerequisite for some features like pure annotation in tree shaking , custom chunk name in bundle splitting

Related issue (if exists)

  1. [Feature Request]: Add support for webpackInclude and webpackExclude magic comments #2335
  2. [Feature Request]: Add support for webpackInclude and webpackExclude magic comments #2335

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: aac026e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IWANABETHATGUY
Copy link
Contributor Author

!bench

@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft March 20, 2023 10:55
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 20, 2023
@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/ten_copy_of_threejs               1.00  1907.6±77.06ms        ? ?/sec    1.04  1990.9±119.22ms        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.00       8.0±0.18s        ? ?/sec    1.00       7.9±0.27s        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review March 20, 2023 11:43
@IWANABETHATGUY
Copy link
Contributor Author

According to the benchmark, the overhead of extra comment info is pretty small.

@IWANABETHATGUY IWANABETHATGUY merged commit 2e8a2a7 into main Mar 20, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the feat/parse_with_comments branch March 20, 2023 13:03
@zackarychapple zackarychapple mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IWANABETHATGUY @jerrykingxyz @h-a-n-a