fix: variable undefined with multiple same import #4356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
checkout added test case
after we introduce source_order for new tree shaking implementation, HarmonyImportSideEffectDependency will be duplicated, and merged by InitFragment, this is aligned behavior with webpack, before it won't be duplicated
but in the old tree shaking implementation will find dependency by its request and dependency_type, so when we want to find
Dependency(101)
, we actually will findDependency(100)
, ifDependency(100)
is unused, then we won't generate the code, soDependency(101)
will be removed mistakenlyTest Plan
Require Documentation?