Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(splitChunks): not matched cacheGroup should not affect cacheGroupIndex #4373

Merged
merged 5 commits into from
Oct 23, 2023
Merged

fix(splitChunks): not matched cacheGroup should not affect cacheGroupIndex #4373

merged 5 commits into from
Oct 23, 2023

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Oct 20, 2023 •
edited
Loading

Summary

Test Plan

  • added

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 20, 2023
JSerFeng
JSerFeng previously approved these changes Oct 20, 2023
View reviewed changes
@JSerFeng JSerFeng dismissed their stale review October 20, 2023 09:14

Not the solution

@ahabhgk ahabhgk requested a review from a team October 20, 2023 12:12
@ahabhgk ahabhgk changed the title fix: chunkIds should not affect chunkLoading order fix(split_chunks): not matched cacheGroup should not affect cacheGroupIndex Oct 20, 2023
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Oct 20, 2023

!canary

@github-actions
Copy link
Contributor

0.3.7-canary-bc422ac-20231020130504

@ahabhgk ahabhgk requested a review from JSerFeng October 23, 2023 04:26
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Oct 23, 2023

!canary

@ahabhgk ahabhgk changed the title fix(split_chunks): not matched cacheGroup should not affect cacheGroupIndex fix(splitChunks): not matched cacheGroup should not affect cacheGroupIndex Oct 23, 2023
@ahabhgk ahabhgk added this pull request to the merge queue Oct 23, 2023
@github-actions
Copy link
Contributor

0.3.7-canary-f7b7f35-20231023050518

Merged via the queue into main with commit 76e4252 Oct 23, 2023
15 checks passed
@ahabhgk ahabhgk deleted the fix-chunkloading-order branch October 23, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @JSerFeng