-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add module parse error #5062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
release: feature related release(mr only)
label
Dec 19, 2023
This was referenced Dec 19, 2023
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Dec 19, 2023
This was referenced Dec 19, 2023
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Test Compatibility Diff
Unpassed tests
|
h-a-n-a
changed the title
feat: align with webpack stats error
feat: add module parse error
Dec 19, 2023
h-a-n-a
force-pushed
the
12-19-feat_align_with_webpack_stats_error
branch
from
December 20, 2023 05:22
89f453f
to
bb48ecd
Compare
h-a-n-a
requested review from
LingyuCoder,
ahabhgk,
IWANABETHATGUY and
ScriptedAlchemy
December 20, 2023 05:23
ahabhgk
reviewed
Dec 20, 2023
...pack_error/tests/out_of_order/multi_json_syntax_error/fixtures__multi_json_syntax_error.snap
Show resolved
Hide resolved
ahabhgk
approved these changes
Dec 20, 2023
ahabhgk
pushed a commit
that referenced
this pull request
Jan 2, 2024
* feat: align with webpack stats error * feat: display module name in overlay * lint * feat: module parse errors/warnings * mistaken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces detailed
StatsError
andModuleParseError
.StatsError['moduleName']
andStatsError['moduleIdentifier']
are both useful in webpack-error-overlay.ModuleParseError
is different to Webpack's, as webpack does not containModuleParseWarning
. Rspack combines these two types together.Note: webpack does have
ModuleWarning
, but it's not the same. Please don't get confused.Parsing error:
Parsing warning:
Note: this does not show up on overlay by default.Test Plan
Require Documentation?