-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: root module is less prone to be wrapped in IIFE #6697
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
canary release moved to https://github.com/web-infra-dev/rspack/actions/workflows/release-canary.yml. |
854a79e
to
92fc32e
Compare
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["threejs_development-mode_10x + exec","threejs_development-mode_10x_hmr + exec","threejs_production-mode_10x + exec"] |
Generally looks good to me, the benchmark shows in an actual case (arco-pro) this is acceptable, but performance has regressed significantly when there are lots of javascript module (threejs 10x), can this be further improved? |
@ahabhgk
|
There isn't a way to get the AST from the module, we don't store the AST on the module, we analyze dependencies from AST (for javascript) then drop it, especially you need to parse the generated code of the module (source has been modified from the original source, so does AST) |
For caching, something like https://github.com/webpack/webpack/blob/34e2561addb0f65a7a6fb0ce7ae1aea4cd1d599f/lib/javascript/JavascriptModulesPlugin.js#L592 but works for caching the inline module result looks good to me |
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["threejs_development-mode_10x + exec","threejs_development-mode_10x_hmr + exec","threejs_production-mode_10x + exec"] |
@ahabhgk |
plugin-test/css-extract/cases/new-url/expected/09a1a1112c577c279435.png
Outdated
Show resolved
Hide resolved
Something wrong in our CI, @SyMind is looking at it |
Patched a commit lost in force-pushing that fix the wrong usage of ReplaceSource, test cases're updated alongside. |
@SyMind Still failing with a retry just now, is this CI issue still being resolved? 🥲 |
@fi3ework I am trying to update the branch to get the latest code. Please wait for the CI to run again. |
@ahabhgk The review was dismissed, PTAL again. |
Summary
Sync up porting webpack/webpack#18348 and webpack/webpack#18349.
Main changes:
find_new_name
from method to functionChecklist