Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow passing function type to assets generator.filename #7206

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

xc2
Copy link
Collaborator

@xc2 xc2 commented Jul 18, 2024

Summary

allow passing function type to generator.filename of asset and asset/resource type.

it is a missing feature of #7191.

it was reported in https://discord.com/channels/977448667919286283/1263141418881519706

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c8e923d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6698bcc6d30f6400081ba8d3

@xc2 xc2 marked this pull request as ready for review July 18, 2024 08:35
@xc2 xc2 requested a review from h-a-n-a July 18, 2024 08:35
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jul 18, 2024

Thanks

@h-a-n-a h-a-n-a merged commit 03b3641 into web-infra-dev:main Jul 18, 2024
35 checks passed
@xc2 xc2 deleted the refactor-missing-type branch July 18, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants