-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better diagnostic report for harmony dependency #7337
Merged
h-a-n-a
merged 4 commits into
web-infra-dev:main
from
shulaoda:feat/better-report-HarmonyImportSideEffectDependency
Jul 30, 2024
Merged
feat: better diagnostic report for harmony dependency #7337
h-a-n-a
merged 4 commits into
web-infra-dev:main
from
shulaoda:feat/better-report-HarmonyImportSideEffectDependency
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
release: feature related release(mr only)
label
Jul 28, 2024
@hardfist cc |
Would you please rebase? |
shulaoda
force-pushed
the
feat/better-report-HarmonyImportSideEffectDependency
branch
from
July 29, 2024 11:35
5f8f294
to
b7ef0bb
Compare
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
shulaoda
force-pushed
the
feat/better-report-HarmonyImportSideEffectDependency
branch
from
July 29, 2024 11:37
b7ef0bb
to
ca0503e
Compare
shulaoda
changed the title
feat: better diagnostic report for HarmonyImportSideEffectDependency
feat: better diagnostic report for harmony dependency
Jul 30, 2024
shulaoda
force-pushed
the
feat/better-report-HarmonyImportSideEffectDependency
branch
from
July 30, 2024 04:56
ca0503e
to
f5e7ce9
Compare
h-a-n-a
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #7336
Checklist