Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better diagnostic report for harmony dependency #7337

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to #7336

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 28, 2024
@LingyuCoder LingyuCoder requested a review from h-a-n-a July 29, 2024 02:54
@shulaoda
Copy link
Collaborator Author

@hardfist cc

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jul 29, 2024

Would you please rebase?

@shulaoda shulaoda force-pushed the feat/better-report-HarmonyImportSideEffectDependency branch from 5f8f294 to b7ef0bb Compare July 29, 2024 11:35
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5d7c6d0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66a87aee0f00310008daa419

@shulaoda shulaoda force-pushed the feat/better-report-HarmonyImportSideEffectDependency branch from b7ef0bb to ca0503e Compare July 29, 2024 11:37
@shulaoda shulaoda marked this pull request as draft July 29, 2024 12:34
@shulaoda shulaoda changed the title feat: better diagnostic report for HarmonyImportSideEffectDependency feat: better diagnostic report for harmony dependency Jul 30, 2024
@shulaoda shulaoda force-pushed the feat/better-report-HarmonyImportSideEffectDependency branch from ca0503e to f5e7ce9 Compare July 30, 2024 04:56
@shulaoda shulaoda marked this pull request as ready for review July 30, 2024 05:36
Copy link
Collaborator

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@h-a-n-a h-a-n-a merged commit 609c2e8 into web-infra-dev:main Jul 30, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants