Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: no need to require entire enhanced-resolve #7343

Merged
merged 1 commit into from
Jul 29, 2024
Merged

perf: no need to require entire enhanced-resolve #7343

merged 1 commit into from
Jul 29, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jul 29, 2024 •
edited
Loading

Summary

Rspack only depend on the CachedInputFileSystem module of enhanced-resolve, so we can remove the index chunk because it is not used.

image

  • The startup time will be 6ms faster:

image

  • Reduced 143KB install size:

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Jul 29, 2024
@chenjiahan chenjiahan requested a review from ahabhgk July 29, 2024 05:16
@chenjiahan chenjiahan merged commit f5223e1 into main Jul 29, 2024
35 checks passed
@chenjiahan chenjiahan deleted the remove_enhanced_resolve_0729 branch July 29, 2024 08:40
@chenjiahan chenjiahan mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@chenjiahan chenjiahan

Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @ahabhgk