fix!: reuseExistingChunk should be false by default #7489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SyMind
previously approved these changes
Aug 7, 2024
chenjiahan
reviewed
Aug 7, 2024
JSerFeng
changed the title
JSerFeng
force-pushed
the
fix/reusing-existing
branch
from
cebacb2
to
83e1b74
Compare
JSerFeng
commented
Aug 7, 2024
packages/rspack-test-tools/tests/configCases/split-chunks/custom-filename/a.js
Show resolved
Hide resolved
chenjiahan
previously approved these changes
Aug 8, 2024
chenjiahan
reviewed
Aug 8, 2024
chenjiahan
reviewed
Aug 8, 2024
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
chenjiahan
approved these changes
Aug 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default value of reuseExistingChunk should be false by default (the same with webpack)
Checklist