Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): improve the configuration of justfile #7526

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Aug 10, 2024

Summary

Related to #7516

  • support windows shell
  • support setup
  • support ready
  • support build
  • support watch

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft August 10, 2024 06:22
Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5dd537f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b9f09ee7e34c000848c7eb

@shulaoda shulaoda marked this pull request as ready for review August 10, 2024 07:17
@shulaoda shulaoda marked this pull request as draft August 10, 2024 07:22
@hardfist
Copy link
Contributor

excellent work!

justfile Show resolved Hide resolved
@shulaoda shulaoda force-pushed the chore/justfile branch 2 times, most recently from 460e320 to c3aa322 Compare August 12, 2024 09:29
@hardfist
Copy link
Contributor

hardfist commented Aug 12, 2024

@shulaoda let's separate this into multi pr, no need to finish things in one PR, current justfile improvement can be landed first.

@hardfist hardfist requested a review from h-a-n-a August 12, 2024 09:55
@shulaoda shulaoda marked this pull request as ready for review August 12, 2024 10:09
justfile Outdated Show resolved Hide resolved
@hardfist
Copy link
Contributor

thanks!

@hardfist hardfist merged commit e311871 into web-infra-dev:main Aug 12, 2024
28 checks passed
@shulaoda shulaoda deleted the chore/justfile branch August 12, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants