Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check SuperProp in walk_call_expression #7530

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

CPunisher
Copy link
Contributor

Summary

Webpack reguard super[foo]() as MemberExpression, but swc distinguishes them. So there should be an extra check.

closes #7477

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CPunisher CPunisher marked this pull request as ready for review August 11, 2024 16:38
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 11, 2024
Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1c3d930
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b9c6d7ce1c5c00074d8b37

@JSerFeng
Copy link
Collaborator

Thanks 🥺

@JSerFeng JSerFeng enabled auto-merge (squash) August 12, 2024 08:46
@JSerFeng JSerFeng merged commit b218285 into web-infra-dev:main Aug 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rspack produces non-working bundles for simple code pattern
2 participants