Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf!: use browserslist-rs for lightningcss #7544

Merged
merged 2 commits into from
Aug 13, 2024
Merged

perf!: use browserslist-rs for lightningcss #7544

merged 2 commits into from
Aug 13, 2024

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Aug 13, 2024 •
edited
Loading

Summary

use browserslist-rs instead of browserslist on js side, so that we can gain slightly more initial setup performance

breaking change

not supports browserslist as parameters now

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 13, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit cec1a59
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66bb04cadc00be000801b762

@JSerFeng JSerFeng force-pushed the perf/lightningcss-browserslist branch from 29e112e to 085367b Compare August 13, 2024 05:01
@JSerFeng JSerFeng force-pushed the perf/lightningcss-browserslist branch from 085367b to f9f5f80 Compare August 13, 2024 05:05
@JSerFeng @h-a-n-a
Update crates/rspack_binding_options/src/options/raw_builtins/raw_lig…
cec1a59 
…htning_css_minimizer.rs

Co-authored-by: Hana <andywangsy@gmail.com>
@JSerFeng JSerFeng force-pushed the perf/lightningcss-browserslist branch from 57ee8d9 to cec1a59 Compare August 13, 2024 07:01
@JSerFeng JSerFeng marked this pull request as ready for review August 13, 2024 07:10
@JSerFeng JSerFeng merged commit ce9b3fa into main Aug 13, 2024
29 checks passed
@JSerFeng JSerFeng deleted the perf/lightningcss-browserslist branch August 13, 2024 07:13
@JSerFeng JSerFeng changed the title perf: use browserslist-rs for lightningcss perf!: use browserslist-rs for lightningcss Aug 13, 2024
@chenjiahan
Copy link
Member

Note: This is a breaking change (targets?: Targets | string[] | string -> string[] | string)

But I think nobody uses the Targets type, which depends on installing the lightningcss package and makes no sense.

@chenjiahan chenjiahan mentioned this pull request Aug 15, 2024
Merged
@chenjiahan chenjiahan mentioned this pull request Sep 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@JSerFeng JSerFeng

Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JSerFeng @chenjiahan @h-a-n-a @ahabhgk