-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): don't inject bundlerInfo in library mode #7567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: document
release: document related release(mr only)
team
The issue/pr is created by the member of Rspack.
labels
Aug 14, 2024
✅ Deploy Preview for rspack canceled.
|
hardfist
force-pushed
the
disable-inject-bundlerInfo
branch
2 times, most recently
from
August 14, 2024 03:57
b50e9f8
to
b230776
Compare
chenjiahan
reviewed
Aug 14, 2024
hardfist
force-pushed
the
disable-inject-bundlerInfo
branch
from
August 14, 2024 06:57
7dd7abc
to
6b0a4d2
Compare
hardfist
changed the title
docs: delete benchmark page (#7566)
feat(core): don't inject bundlerInfo in library mode
Aug 14, 2024
github-actions
bot
added
release: feature
release: feature related release(mr only)
and removed
release: document
release: document related release(mr only)
labels
Aug 14, 2024
hardfist
commented
Aug 14, 2024
packages/rspack-test-tools/tests/configCases/output/library-truthy/index.js
Show resolved
Hide resolved
hardfist
force-pushed
the
disable-inject-bundlerInfo
branch
from
August 14, 2024 07:09
6b0a4d2
to
db557fc
Compare
fi3ework
previously approved these changes
Aug 14, 2024
packages/rspack-test-tools/tests/configCases/output/library-truthy/index.js
Show resolved
Hide resolved
hardfist
force-pushed
the
disable-inject-bundlerInfo
branch
from
August 14, 2024 07:27
db557fc
to
6748436
Compare
LingyuCoder
previously approved these changes
Aug 14, 2024
hardfist
force-pushed
the
disable-inject-bundlerInfo
branch
from
August 14, 2024 07:48
67157c4
to
92ea740
Compare
hardfist
force-pushed
the
disable-inject-bundlerInfo
branch
from
August 15, 2024 07:45
92ea740
to
8f5e6f6
Compare
LingyuCoder
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #7563, don't inject bundlerInfo in library mode
Checklist