Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve esm harmony dependencies structure #7576

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

shulaoda
Copy link
Contributor

Summary

Related to #7422

This job is a bit large, and I have temporarily managed dependencies that already have loc. I need to evaluate whether the current approach is acceptable.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit aed9463
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66bc73e6786e6d000856a043

@shulaoda
Copy link
Contributor Author

The DependencyLocation in webpack is as follows. At present, I have only considered RealDependencyLocation because I have not encountered the situation of SyntheticDependencyLocation yet, and it seems that this can be considered to be ignored.

/**
 * @typedef {object} RealDependencyLocation
 * @property {SourcePosition} start
 * @property {SourcePosition=} end
 * @property {number=} index
 */

/**
 * @typedef {object} SyntheticDependencyLocation
 * @property {string} name
 * @property {number=} index
 */

/** @typedef {SyntheticDependencyLocation | RealDependencyLocation} DependencyLocation */

@shulaoda
Copy link
Contributor Author

@h-a-n-a cc

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Aug 14, 2024

Looks good to me. Would you please also list some milestones and designs for this refactor?
You can also turn the issue into a tracking issue just to see this refactor as a whole in a bigger picture.

@shulaoda shulaoda changed the title feat: improve dependency structure specification refactor: improve esm harmony dependencies structure Aug 14, 2024
@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label Aug 14, 2024
@h-a-n-a h-a-n-a merged commit 827758e into web-infra-dev:main Aug 15, 2024
35 checks passed
@shulaoda shulaoda deleted the feat/improve-dependency-loc branch August 15, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants