feat(rspack_plugin_swc_js_minimizer): add minify option #7599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
fi3ework
force-pushed
the
disable-minify
branch
from
aaa8b86
to
da509a4
Compare
|
LGTM, @ahabhgk |
ahabhgk
reviewed
Aug 19, 2024
fi3ework
force-pushed
the
disable-minify
branch
from
da509a4
to
b4abc23
Compare
ahabhgk
previously approved these changes
Aug 19, 2024
ahabhgk
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new JS minimize option to support alter
minifyconfig in swc codegen, previously it was hard coded astrue.The usage is to enable some compress features, but without minify the whitespace in Rslib for now.
Checklist