Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): remove unnecessary enum for resolver #7631

Merged
merged 1 commit into from
Aug 20, 2024
Merged

refactor(core): remove unnecessary enum for resolver #7631

merged 1 commit into from
Aug 20, 2024

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Aug 20, 2024 •
edited
Loading

Summary

we only have one resolver implementation now so it's unnecessary to use enum to wrap resolver

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f68286b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c489e0da78a60008294aee

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 20, 2024
@hardfist hardfist merged commit dd6e27a into main Aug 20, 2024
35 checks passed
@hardfist hardfist deleted the yj/remove-enum branch August 20, 2024 16:27
@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees

@hardfist hardfist

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardfist @ahabhgk